Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rule type name that has no pills. #4333

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Fix rule type name that has no pills. #4333

merged 1 commit into from
Sep 2, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Aug 30, 2024

Summary

We recently added the possibility to display can_remediate and release_phase pills, if available, near to rule type name. If no pills were available, we erroneously displayed ().

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt
Fix rule type name that has no pills.
685eef0 
We recently added the possibility to display `can_remediate` and
`release_phase` pills, if available, near to rule type name. If no
pills were available, we erroneously displayed `()`.
@blkt blkt self-assigned this Aug 30, 2024
@coveralls
Copy link

Coverage Status

coverage: 53.94%. remained the same
when pulling 685eef0 on fix/ruletype-name-pills
into d3523eb on main.

@blkt blkt merged commit e1845dc into main Sep 2, 2024
22 checks passed
@blkt blkt deleted the fix/ruletype-name-pills branch September 2, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson approved these changes

Assignees

@blkt blkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blkt @coveralls @evankanderson